Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat: OIDC account recovery #273

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Conversation

matias-gonz
Copy link
Member

Description

Additional context

matias-gonz and others added 5 commits February 6, 2025 10:54
* feat: empty GuardianRecoveryValidator

Created GuardianRecoveryValidator structure to start development

* feat: methods to add a guardian

implemented proposeRecoveryKey and addRecoveryKey with tests.

* fix: reverting when guardian not found

When a user tries to remove a guardian that does not exist
we revert the tx.

* fix: uint to uint256

Using uint256 instead of uint everywhere.

* feat: add validateTransaction implementation to GuardianRecoveryValidatior

* chore: refactor tests

* chore: clean up code

* feat: improve init method

* feat: simplify initRecovery method

* chore: resolve build issues

* chore: resolve build issues

* chore: resolve pr comments

* feat: restore guardiansFor method

* chore: remove unused access to accountGuardians

* feat: make guardian recovery validator contract proxy-able

* chore: simplify initializer function name

* feat: add function to retrieve guarded accounts

* fix: improve recovery validator logic

* feat: allow paymaster calls to GuardianRecoveryValidator

* feat: fix guardian recovery validator compilation

* fix: add compiler version and remove unwanted comments

* fix: bugs and jsdoc format to match rest of package

* fix: test that included guardian contract

* feat: add passkey to account relation

* feat: prevent account overlap

* feat: improve registered accounts logic

* fix: tests

* fix: unknown accounts

* fix: discard recovery bug

* fix: move account verifications

* feat: add guardian added time to guardian information

* fix: deployment

* fix: address to account id is not empty when initiating recovery

* fix: remove double save on guardedAccounts

* Fix/paymaster-recovery-validator (#291)

* fix: add missing functions from recovery validator to paymaster

* feat: add guardian not self check

---------

Co-authored-by: calvo.generico <[email protected]>
Co-authored-by: Lukasz Romanowski <[email protected]>
Co-authored-by: Agustin Aon <[email protected]>
* Add getOidcKeyRegistryContract

* Add 'helloworld' test

* Test should set one key

* Test should revert when a non-owner tries to set a key

* Test should correctly implement circular key storage

* Update test/OidcKeyRegistryTest.ts

* Add Oidc to dictionary
* Add OidcValidator

* Update install and uninstall

* Add addValidationKey

* Add OidcValidator.validateTransaction

* Add pkop to dictionary

* Remove OidcValidatorTest
@calvogenerico calvogenerico force-pushed the feat/oidc-account-recovery branch from c7dab6d to ca9fa35 Compare February 14, 2025 18:17
calvogenerico and others added 5 commits February 17, 2025 19:38
added auto generated code for verifier
added oidc validator and its deps to deploy scripts
touches to follow project style and make lint pass
* feat: empty GuardianRecoveryValidator

Created GuardianRecoveryValidator structure to start development

* feat: methods to add a guardian

implemented proposeRecoveryKey and addRecoveryKey with tests.

* fix: reverting when guardian not found

When a user tries to remove a guardian that does not exist
we revert the tx.

* fix: uint to uint256

Using uint256 instead of uint everywhere.

* feat: add validateTransaction implementation to GuardianRecoveryValidatior

* chore: refactor tests

* chore: clean up code

* feat: improve init method

* feat: simplify initRecovery method

* chore: resolve build issues

* chore: resolve build issues

* chore: resolve pr comments

* feat: restore guardiansFor method

* chore: remove unused access to accountGuardians

* feat: make guardian recovery validator contract proxy-able

* chore: simplify initializer function name

* feat: add function to retrieve guarded accounts

* fix: improve recovery validator logic

* feat: allow paymaster calls to GuardianRecoveryValidator

* feat: fix guardian recovery validator compilation

* fix: add compiler version and remove unwanted comments

* fix: bugs and jsdoc format to match rest of package

* fix: test that included guardian contract

* feat: add passkey to account relation

* feat: prevent account overlap

* feat: improve registered accounts logic

* fix: tests

* fix: unknown accounts

* fix: discard recovery bug

* fix: move account verifications

* feat: add guardian added time to guardian information

* fix: deployment

* fix: address to account id is not empty when initiating recovery

* fix: remove double save on guardedAccounts

* Fix/paymaster-recovery-validator (#291)

* fix: add missing functions from recovery validator to paymaster

* feat: add guardian not self check

---------

Co-authored-by: Lukasz Romanowski <[email protected]>
Co-authored-by: Agustin Aon <[email protected]>
Co-authored-by: Matías Ignacio González <[email protected]>
* Deploy OidcRecoveryValidator

* Make OidcRecoveryValidator initializable

* Remove immutable

* Add OidcValidator to paymaster

* lint

* fix: test ExampleAuthServerPaymaster

* fix: added missing parameters for init

added missing parameters for init

---------

Co-authored-by: calvo.generico <[email protected]>
remove redeployed oidc validator
added missing word to dict.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants